Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Fixes inconsistencies in the class and file naming in google_maps_flutter_ios:

  • Standardizes on FGM instead of a mix of FGM and the older FLT.
  • Removes GoogleMaps from most class names, as now that we are using FGM we don't need to further specific that it's related to Google Maps, and removing that makes it much easier to see the useful part of the name.
  • Ensures that all files have a prefix matching their class, for consistency.
  • Removes prefixing from all test classes and files, since tests don't need prefixes as they aren't part of client builds.

Part of flutter/flutter#102601

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@stuartmorgan-g
Copy link
Collaborator Author

This is another one I should have done before #10852, but I can reconcile the two PRs once one lands. This annoys me every time I try to work in this plugin, and after all the recent time I've spent in it I couldn't take it any more 😐

@stuartmorgan-g stuartmorgan-g changed the title [google_maps_flutter] Standardize [google_maps_flutter] Standardize class and file names Feb 4, 2026
@stuartmorgan-g stuartmorgan-g changed the title [google_maps_flutter] Standardize class and file names [google_maps_flutter] Standardize iOS class and file names Feb 4, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes Objective-C class and file names in the google_maps_flutter_ios package. The changes replace the FLT prefix with FGM, remove the GoogleMaps substring from many class names, and rename files to match their class names. Test classes and files have had prefixes removed, and test utility files have been moved into a TestUtils directory. The package version has been updated and a corresponding entry was added to the changelog.

@stuartmorgan-g stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Feb 10, 2026
@vashworth
Copy link
Contributor

Looks like there's still issues with FGMGroundOverlayController.m in the sdk packages

@stuartmorgan-g
Copy link
Collaborator Author

I think while I was trying to fix whatever weird git state one copy of that file somehow ended up in (blame showed uncommitted changes to those lines, but status and add said everything was unchanged), I must have messed up the copy source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants